> diff --git a/kernel/bpf/backtrack.c b/kernel/bpf/backtrack.c
> index 40bd04421a991..a2b18a9f1694c 100644
> --- a/kernel/bpf/backtrack.c
> +++ b/kernel/bpf/backtrack.c
> @@ -214,7 +214,6 @@ static inline bool bt_is_reg_set(struct backtrack_state 
> *bt, u32 reg)
>       return bt->reg_masks[bt->frame] & (1 << reg);
>  }
>
> -
>  /* format registers bitmask, e.g., "r0,r2,r4" for 0x15 mask */
>  static void fmt_reg_mask(char *buf, ssize_t buf_sz, u32 reg_mask)
>  {

[ ... ]

> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 164d16c243ca6..cdb79a66b156f 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -635,7 +635,6 @@ static void __mark_dynptr_reg(struct bpf_reg_state *reg,
>                             enum bpf_dynptr_type type,
>                             bool first_slot, int id, int parent_id);
>
> -
>  static void mark_dynptr_stack_regs(struct bpf_verifier_env *env,
>                                  struct bpf_reg_state *sreg1,
>                                  struct bpf_reg_state *sreg2,

[ ... ]

> @@ -18361,8 +18352,6 @@ static void release_insn_arrays(struct 
> bpf_verifier_env *env)
>               bpf_insn_array_release(env->insn_array_maps[i]);
>  }
>
> -
> -
>  /* The verifier does more data flow analysis than llvm and will not
>   * explore branches that are dead at run time. Malicious programs can
>   * have dead code too. Therefore replace all dead at-run-time code
> @@ -18390,8 +18379,6 @@ static void sanitize_dead_code(struct 
> bpf_verifier_env *env)
>       }
>  }
>
> -
> -
>  static void free_states(struct bpf_verifier_env *env)
>  {
>       struct bpf_verifier_state_list *sl;

This isn't a bug, but it looks like one adjacent blank-line pair is still
left in verifier.c. Inside the kfunc argument loop in check_kfunc_args(),
around the code that checks:

        if (bpf_register_is_null(reg) && type_may_be_null(kf_arg_type))

there's a blank line pair that appears to fit the same pattern this patch
removes everywhere else. The changelog states the goal is to drop the
adjacent blank lines that have accumulated over time, and the patch removes
30 blank lines across the directory, but this one instance seems to have
been overlooked. Was that one intentionally kept, or could it be folded
into this patch so the whole directory is done in one pass?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31716447858

Reply via email to