On Sat, Aug 15, 2026 at 05:05:59PM +0100, Bradley Morgan wrote: > The test covers the parse error, the out of range value and the > first value failing. That's the right coverage. > > The shellcheck disable should say why. The test functions are only > called through the dispatch string, so shellcheck thinks they are > unreachable. I expect to remove this in the new sysctl selftests.
> > run_int_array_no_partial_update() uses spaces for its comment lines > while the code uses tabs. good catch > > reset_vals() has no case for int_0003, so sysctl_test_0013 calls it > for nothing. Drop the call or add a case for int_0003. The TARGET is reset to "". right? I'm reluctant to do more work on the sysctl.sh file as everything will probably be replaced. Thx Best > > Nits aside, the test does what it should: > > Reviewed-by: Bradley Morgan <[email protected]> > Thanks!
signature.asc
Description: PGP signature
