> This new option is not exercised by any in-tree test. > Do you have any special use case that needs it? > Otherwise either its useful and in-tree tests should run it, or it's > not useful and we shouldn't merge this patch either..
Thanks for the review. I've added an in-tree test to udpgso_bench.sh that exercises TCP payload verification for IPv4 and IPv6 and checks the receiver's exit status. I'll include this test in v2. Jakub Kicinski <[email protected]> 於 2026年9月10日週四 上午9:08寫道： > > On Sun, 6 Sep 2026 22:56:43 +0800 shuo huang wrote: > > udpgso_bench_rx supports UDP payload verification but rejects the > > combination of TCP and verification mode. Its TCP receive path discards > > the payload, so it cannot check the data generated by udpgso_bench_tx. > > > > Read the TCP payload into a buffer when verification is requested > > and check it against the transmitter's repeating alphabetic > > pattern. Preserve the verification position across recv() calls > > because TCP does not preserve send boundaries. Restart the pattern > > at the payload length supplied with -l, matching the transmitter's > > pattern restart on each message. > > > > Require a nonzero -l value for TCP verification and retain the existing > > discard path when verification is disabled. > > This new option is not exercised by any in-tree test. > Do you have any special use case that needs it? > Otherwise either its useful and in-tree tests should run it, or it's > not useful and we shouldn't merge this patch either.. > -- > pw-bot: cr
