Daniel Zahka wrote: > Future work will only allow rx-assoc and tx-assoc to be performed when > the sock is in TCP_ESTABLISHED state. > > Several assoc_ tests, as well as dev_rotate_spi, test using the rx-assoc > and tx-assoc uapi calls against sockets in TCP_CLOSE state. > These tests don't involve sending or receiving data, nor involve looking > up psp device by dst entry, so using a disposable disconnected socket > was just a convenience. These can be replaced by a disposable loopback > socket. > > The loopback sockets are IPv4, where the sockets they replace were > AF_INET6. This doesn't reduce coverage, since the assoc handlers accept > any TCP socket and don't look at the address family. > > Some users of rx-assoc and tx-assoc on closed sockets are left if they > validate errors that are returned before the kernel will check the > socket for TCP_ESTABLISHED. > > Signed-off-by: Daniel Zahka <[email protected]>
Reviewed-by: Willem de Bruijn <[email protected]>
