On Thu, Oct 01, 2026 at 04:18:35PM -0700, Sean Christopherson wrote: > On Thu, Oct 01, 2026, Leonardo Bras wrote: > > On Wed, Sep 30, 2026 at 01:31:25PM -0700, Sean Christopherson wrote: > > > > "Dirty-ring not supported in this kernel\n"); > > > > > > "this kernel" could be misleading, some architectures simply don't > > > support the > > > dirty ring. > > Hmm, the counter argument is that this is actually accurate if those > architectures > were to gain support in the future, but someone ran this on an older kernel... > > > So, do you suggest keeping it simple by printing "Dirty-ring not supported"? > > Yeah, unless you have a better idea. Actually, even though Kconfig isn't > user- > controllable, it's still there in the .config. So maybe something like this? > > TEST_ASSERT(cap, "Dirty-ring not supported, check > CONFIG_HAVE_KVM_DIRTY_RING?"); > > That would at least give the user a breadcrumb to start with.
Yeah, that looks better. Thanks! Leo
