On Mon, Oct 05, 2026 at 04:44:45PM +0530, Komal Bajaj wrote: > The Shikra LPAICP PAS requires three IOMMU entries. However, > qcom,shikra-pas.yaml inherits the `iommus` schema from > qcom,pas-common.yaml, which limits property to a single entry. > > As a result, the LPAICP-specific `maxItems: 3` constraint conflicts > with the inherited `maxItems: 1` constraint, and a valid LPAICP node > fails schema validation. > > Remove the pas-common schema reference and specify IOMMU entry limit > for each Shikra PAS compatible: one entry for CDSP and MPSS, and > three entries for LPAICP. > > Signed-off-by: Komal Bajaj <[email protected]> > --- > .../devicetree/bindings/remoteproc/qcom,shikra-pas.yaml | 15 > +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml > b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml > index 34a2f15e9361..4196f61a8ba0 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml > @@ -32,6 +32,9 @@ properties: > items: > - const: xo > > + interconnects: > + maxItems: 1 > + > memory-region: > minItems: 1 > maxItems: 2 > @@ -92,10 +95,14 @@ required: > - compatible > - reg > - memory-region > + - clocks > + - clock-names > + - interrupts > + - interrupt-names > + - qcom,smem-states > + - qcom,smem-state-names > > allOf: > - - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
I think the right approach would be to remove iommu from the common binding and let the corresponding target put the constraints. > - > - if: > properties: > compatible: > @@ -112,6 +119,8 @@ allOf: > maxItems: 1 > firmware-name: > maxItems: 1 > + iommus: > + maxItems: 1 > power-domains: > items: > - description: CX power domain > @@ -134,6 +143,8 @@ allOf: > minItems: 2 > firmware-name: > minItems: 2 > + iommus: > + maxItems: 3 > power-domains: false > power-domain-names: false > > > -- > 2.34.1 > -- -Mukesh Ojha
