On Sun, Oct 11, 2026 at 01:23:25 +0000, [email protected] wrote:
> [Severity: Medium]
> The new header comment says:
>
> so that the GSO packets encapsulated by bareudp are segmented in software.
>
> Does that hold for the two Unicast MPLS stream tests?
[...]
> Should the MPLS stream tests be dropped? Alternatively, the header comment
> and commit message could be updated and CONFIG_NET_MPLS_GSO added to the
> selftests config.
Right. Counting calls with the function profiler, the MPLS streams only
go through mpls_gso_segment() and never reach skb_udp_tunnel_segment(),
while the IPv4 streams do. With mpls_gso blocked from loading, both
MPLS streams fail. (When it is a module, it does get loaded here, as a
softdep of mpls_iptunnel, but the tests do not reach the tunnel GSO
path anyway.)
I will drop the MPLS stream tests in v2.
> [Severity: Low]
> exit_cleanup() calls cleanup_all_ns before the new `[ -n
> "${TMPFILE}" ] && rm -f "${TMPFILE}"`.
[...]
> Would it help to remove TMPFILE before calling cleanup_all_ns, or to
> tolerate its failure?
Yes, v2 will remove it first.
pw-bot: cr
