Move lib/test_memcat_p.c to lib/tests/memcat_p_kunit.c and convert it to use KUnit.
This change switches the ad-hoc test code to standard KUnit test cases. The test data remains the same, but the verification logic is updated to use KUNIT_EXPECT_* macros. All allocations are made test managed, so the manual error unwinding paths and the empty module exit hook are no longer needed, and a failure now reports which element mismatched instead of a single pr_err() message. CONFIG_TEST_MEMCAT_P keeps its name so that the defconfigs enabling it stay valid; it now depends on KUNIT and defaults to KUNIT_ALL_TESTS, like the other lib KUnit tests. Those defconfigs already select KUNIT and KUNIT_ALL_TESTS, so they keep turning the test on unchanged. Signed-off-by: Wang Yibo <[email protected]> --- lib/Kconfig.debug | 4 +- lib/Makefile | 1 - lib/test_memcat_p.c | 116 ------------------------------------- lib/tests/Makefile | 1 + lib/tests/memcat_p_kunit.c | 83 ++++++++++++++++++++++++++ 5 files changed, 87 insertions(+), 118 deletions(-) delete mode 100644 lib/test_memcat_p.c create mode 100644 lib/tests/memcat_p_kunit.c diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 6b24a2c89b84..66dfffa48fc3 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -3314,7 +3314,9 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. config TEST_MEMCAT_P - tristate "Test memcat_p() helper function" + tristate "KUnit test for memcat_p() helper function" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS help Test the memcat_p() helper for correctly merging two pointer arrays together. diff --git a/lib/Makefile b/lib/Makefile index dfab958327c5..d0e8dd7e364c 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -97,7 +97,6 @@ obj-$(CONFIG_TEST_MAPLE_TREE) += test_maple_tree.o obj-$(CONFIG_TEST_PARMAN) += test_parman.o obj-$(CONFIG_TEST_KMOD) += test_kmod.o obj-$(CONFIG_TEST_DEBUG_VIRTUAL) += test_debug_virtual.o -obj-$(CONFIG_TEST_MEMCAT_P) += test_memcat_p.o obj-$(CONFIG_TEST_OBJAGG) += test_objagg.o obj-$(CONFIG_TEST_MEMINIT) += test_meminit.o obj-$(CONFIG_TEST_LOCKUP) += test_lockup.o diff --git a/lib/test_memcat_p.c b/lib/test_memcat_p.c deleted file mode 100644 index 62f1633b30f8..000000000000 --- a/lib/test_memcat_p.c +++ /dev/null @@ -1,116 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Test cases for memcat_p() in lib/memcat_p.c - */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt - -#include <linux/string.h> -#include <linux/slab.h> -#include <linux/module.h> - -struct test_struct { - int num; - unsigned int magic; -}; - -#define MAGIC 0xf00ff00f -/* Size of each of the NULL-terminated input arrays */ -#define INPUT_MAX 128 -/* Expected number of non-NULL elements in the output array */ -#define EXPECT (INPUT_MAX * 2 - 2) - -static int __init test_memcat_p_init(void) -{ - struct test_struct **in0, **in1, **out, **p; - int err = -ENOMEM, i, r, total = 0; - - in0 = kzalloc_objs(*in0, INPUT_MAX); - if (!in0) - return err; - - in1 = kzalloc_objs(*in1, INPUT_MAX); - if (!in1) - goto err_free_in0; - - for (i = 0, r = 1; i < INPUT_MAX - 1; i++) { - in0[i] = kmalloc_obj(**in0); - if (!in0[i]) - goto err_free_elements; - - in1[i] = kmalloc_obj(**in1); - if (!in1[i]) { - kfree(in0[i]); - goto err_free_elements; - } - - /* lifted from test_sort.c */ - r = (r * 725861) % 6599; - in0[i]->num = r; - in1[i]->num = -r; - in0[i]->magic = MAGIC; - in1[i]->magic = MAGIC; - } - - in0[i] = in1[i] = NULL; - - out = memcat_p(in0, in1); - if (!out) - goto err_free_all_elements; - - err = -EINVAL; - for (i = 0, p = out; *p && (i < INPUT_MAX * 2 - 1); p++, i++) { - total += (*p)->num; - - if ((*p)->magic != MAGIC) { - pr_err("test failed: wrong magic at %d: %u\n", i, - (*p)->magic); - goto err_free_out; - } - } - - if (total) { - pr_err("test failed: expected zero total, got %d\n", total); - goto err_free_out; - } - - if (i != EXPECT) { - pr_err("test failed: expected output size %d, got %d\n", - EXPECT, i); - goto err_free_out; - } - - for (i = 0; i < INPUT_MAX - 1; i++) - if (out[i] != in0[i] || out[i + INPUT_MAX - 1] != in1[i]) { - pr_err("test failed: wrong element order at %d\n", i); - goto err_free_out; - } - - err = 0; - pr_info("test passed\n"); - -err_free_out: - kfree(out); -err_free_all_elements: - i = INPUT_MAX; -err_free_elements: - for (i--; i >= 0; i--) { - kfree(in1[i]); - kfree(in0[i]); - } - - kfree(in1); -err_free_in0: - kfree(in0); - - return err; -} - -static void __exit test_memcat_p_exit(void) -{ -} - -module_init(test_memcat_p_init); -module_exit(test_memcat_p_exit); - -MODULE_DESCRIPTION("Test cases for memcat_p() in lib/memcat_p.c"); -MODULE_LICENSE("GPL"); diff --git a/lib/tests/Makefile b/lib/tests/Makefile index 3cac3b63a752..8ba5fb73dc0b 100644 --- a/lib/tests/Makefile +++ b/lib/tests/Makefile @@ -38,6 +38,7 @@ CFLAGS_longest_symbol_kunit.o += $(call cc-disable-warning, missing-prototypes) obj-$(CONFIG_LONGEST_SYM_KUNIT_TEST) += longest_symbol_kunit.o obj-$(CONFIG_MEMCPY_KUNIT_TEST) += memcpy_kunit.o +obj-$(CONFIG_TEST_MEMCAT_P) += memcat_p_kunit.o obj-$(CONFIG_MIN_HEAP_KUNIT_TEST) += min_heap_kunit.o CFLAGS_overflow_kunit.o = $(call cc-disable-warning, tautological-constant-out-of-range-compare) obj-$(CONFIG_OVERFLOW_KUNIT_TEST) += overflow_kunit.o diff --git a/lib/tests/memcat_p_kunit.c b/lib/tests/memcat_p_kunit.c new file mode 100644 index 000000000000..261ec2e69787 --- /dev/null +++ b/lib/tests/memcat_p_kunit.c @@ -0,0 +1,83 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Test cases for memcat_p() in lib/memcat_p.c + */ + +#include <kunit/test.h> + +#include <linux/slab.h> +#include <linux/string.h> + +struct test_struct { + int num; + unsigned int magic; +}; + +#define MAGIC 0xf00ff00f +/* Size of each of the NULL-terminated input arrays */ +#define INPUT_MAX 128 +/* Expected number of non-NULL elements in the output array */ +#define EXPECT (INPUT_MAX * 2 - 2) + +static void memcat_p_test(struct kunit *test) +{ + struct test_struct **in0, **in1, **out, **p; + int i, r, total = 0; + + in0 = kunit_kcalloc(test, INPUT_MAX, sizeof(*in0), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, in0); + + in1 = kunit_kcalloc(test, INPUT_MAX, sizeof(*in1), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, in1); + + for (i = 0, r = 1; i < INPUT_MAX - 1; i++) { + in0[i] = kunit_kmalloc(test, sizeof(**in0), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, in0[i]); + + in1[i] = kunit_kmalloc(test, sizeof(**in1), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, in1[i]); + + /* lifted from test_sort.c */ + r = (r * 725861) % 6599; + in0[i]->num = r; + in1[i]->num = -r; + in0[i]->magic = MAGIC; + in1[i]->magic = MAGIC; + } + + in0[i] = NULL; + in1[i] = NULL; + + out = memcat_p(in0, in1); + KUNIT_ASSERT_NOT_NULL(test, out); + + for (i = 0, p = out; *p && (i < INPUT_MAX * 2 - 1); p++, i++) { + total += (*p)->num; + KUNIT_EXPECT_EQ(test, (*p)->magic, MAGIC); + } + + KUNIT_EXPECT_EQ(test, total, 0); + KUNIT_EXPECT_EQ(test, i, EXPECT); + + for (i = 0; i < INPUT_MAX - 1; i++) { + KUNIT_EXPECT_PTR_EQ(test, out[i], in0[i]); + KUNIT_EXPECT_PTR_EQ(test, out[i + INPUT_MAX - 1], in1[i]); + } + + kunit_kfree(test, out); +} + +static struct kunit_case memcat_p_test_cases[] = { + KUNIT_CASE(memcat_p_test), + {} +}; + +static struct kunit_suite memcat_p_test_suite = { + .name = "memcat_p", + .test_cases = memcat_p_test_cases, +}; + +kunit_test_suite(memcat_p_test_suite); + +MODULE_DESCRIPTION("Test cases for memcat_p() in lib/memcat_p.c"); +MODULE_LICENSE("GPL"); base-commit: 4056b3c9d3c92ea45955641dbafeb9b960e146ef -- 2.25.1
