> [Severity: Low] > > Should the return value of mctp_usblib_test_rx_complete() be checked > here, > as the other call sites in this file do? Yes, good catch.
> [Severity: High] > > Does this leak the skb data buffer? kfree() releases only the struct > sk_buff itself and skips skb_release_all()/skb_free_head(), so skb->head is > never freed. Yes it does, will fix. > [Severity: Low] > > This isn't a bug, but i is never used once the invocations are unrolled, so > this emits a -Wunused-variable warning and fails the build under > CONFIG_WERROR with CONFIG_MCTP_TRANSPORT_USBLIB_TEST enabled. The > declaration is removed again by the next patch in the series, "net: mctp: > usblib: Add tests of invalid headers", so the final state of the series is > clean; could it be dropped in this patch instead to keep the series > bisectable? Will remove.
