On Wed, Oct 14, 2026 at 03:17:00AM +0200, Jianbo Liu wrote: > The handler is only in tc_acts_fdb[] and only accepts flowtable flows, > so NIC mode and tc flower rules are rejected as before. Looks good. > > The comment says what the code does, but the consequence is worth a line > in the commit message. Because the action is ignored, the priority only > reaches packets still on the software fast path, where > nf_flow_offload_forward() sets skb->priority. Once the flow is offloaded > to the FDB, mlx5 forwards it without touching skb->priority, so the > offloaded packets do not carry it. Refusing the flow to honor the > priority would keep it in software, so ignoring the action and keeping > the offload is the better tradeoff, it is just not obvious from the code. > > I checked this on ConnectX-7: with the series the priority-carrying > flows stay offloaded to the FDB like plain flows, and without patch 1/3 > they fallback to software. > > Nit: "prio" already means flow table priority in mlx5; skbedit_prio > would be clearer. Not a blocker. > > Reviewed-by: Jianbo Liu <[email protected]>
Hi Jianbo, Thanks a lot for the review and for testing this on ConnectX-7! I will send v4 with your suggestions this weekend. Best, Julius
