YAMAMOTO Takashi wrote:
>> Li Zefan wrote:
>>> No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should
>>> be VM_BUG_ON(page).
>>>
>>> Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
>>> Acked-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]>
>> pc is of type page_cgroup and we use list_for_each_entry_safe_reverse. Not
>> sure
>> why we can't bug on pc.
>
> pc is dereferenced before this VM_BUG_ON.
>
> YAMAMOTO Takashi
>
OK, so the VM_BUG_ON needs to move to an earlier location. Agreed.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
