Hi, On Feb 16, 2008 9:52 PM, Andreas Schwab <[EMAIL PROTECTED]> wrote: > Since commit aaa04c28cb9a1efd42541fdb7ab648231c2a2263 [blk_end_request: > changing ide-cd (take 4)] I cannot burn any CD/DVD any more, getting the > following error from wodim: > > Errno: 0 (Success), write_g1 scsi sendcmd: no error > CDB: 2A 00 00 00 00 00 00 00 1F 00 > status: 0x2 (CHECK CONDITION) > Sense Bytes: 70 00 05 00 00 00 00 0E 00 00 00 00 21 02 00 00 > Sense Key: 0x5 Illegal Request, Segment 0 > Sense Code: 0x21 Qual 0x02 (invalid address for write) Fru 0x0 > Sense flags: Blk 0 (not valid) > resid: 63488
blk_end_request: changing ide-cd (take 4) This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. In PIO mode, ide-cd (cdrom_newpc_intr()) needs to defer end_that_request_last() until the device clears DRQ_STAT and raises an interrupt after end_that_request_first(). So blk_end_request() has to return without completing request even if no leftover in the request. ide-cd uses blk_end_request_callback() and a dummy callback function, which just returns value '1', to tell blk_end_request_callback() about that. Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> [...] I looked at the commit again but nothing seems obviously wrong (probably there was a silent change in the behavior of block layer API that upsets ide-cd)... Kiyoshi/Jens: please follow up on this bug. Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/