RESENT: Add Maintainers
free_irq() does not disable/mask the irq, in case disable or shutdown in struct
irq_chip is left uninitilazied.
/**
* struct irq_chip - hardware interrupt chip descriptor
*
* @name: name for /proc/interrupts
* @startup: start up the interrupt (defaults to ->enable if NULL)
* @shutdown: shut down the interrupt (defaults to ->disable if NULL)
* @enable: enable the interrupt (defaults to chip->unmask if NULL)
* @disable: disable the interrupt (defaults to chip->mask if NULL)
According to linux/irq.h struct irq_chip information,
chip->disable should default to chip->mask if NULL.
However irq_chip_set_defaults(struct irq_chip *chip) will set it to
default_disable an empty function.
In earlier kernel versions such as 2.6.19 default_disable called chip->mask.
In 2.6.22 and 2.6.24 default_disable is an empty function.
Looking through various architectures, it's still pretty common that disable
and shutdown is NULL.
Do I miss something here?
Signed-off-by: Michael Hennerich <[EMAIL PROTECTED]>
Index: irq/chip.c
===================================================================
--- irq/chip.c (revision 4276)
+++ irq/chip.c (working copy)
@@ -233,6 +233,10 @@
*/
static void default_disable(unsigned int irq) {
+ struct irq_desc *desc = irq_desc + irq;
+
+ desc->chip->mask(irq);
+ desc->status |= IRQ_MASKED;
}
/*
Best regards,
Michael
------------------------------------------------------------------
********* Analog Devices GmbH [EMAIL PROTECTED]
** ***** Systems Engineering
** ** Wilhelm-Wagenfeld-Strasse 6
** ***** D-80807 Munich
********* Germany
Registergericht München HRB 40368, Geschäftsführer: Thomas Wessel, Vincent
Roche, Joseph E. McDonough
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
