On Wed, Feb 20, 2008 at 12:10:36PM -0800, Randy Dunlap wrote: > Greg KH wrote: >> On Mon, Feb 18, 2008 at 04:22:16PM -0800, Randy Dunlap wrote: >>> From: Randy Dunlap <[EMAIL PROTECTED]> >>> >>> Fix firmware_sample_firmware_class module to build without error. >>> sysfs.h already has the function prototypes and has them correctly. >>> >>> Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: >>> conflicting types for 'sysfs_remove_bin_file' >>> include/linux/sysfs.h:100: error: previous declaration of >>> 'sysfs_remove_bin_file' was here >>> >>> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> >>> --- >>> Documentation/firmware_class/firmware_sample_firmware_class.c | 3 --- >>> 1 file changed, 3 deletions(-) >> Can we move this file to the samples/ directory, so the build will catch >> stuff like this? >> What's the final version of this patch? > > I've moved it to samples/, but it (still) has a build problem: > > ERROR: "firmware_class" > [samples/firmware_class/firmware_sample_firmware_class.ko] undefined! > > Can you give me hint(s) about how to fix that?
Ah, yeah, that class went away a while ago. Care to send me the patch you have, and I'll be glad to fix it up and get it in? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/