David wrote: + /* add additional MPOL_* modes here */ That doesn't explicitly say what I was most worried about saying, which is that those MPOL_* terms have values visible in the kernel's public API, and it does say more than might be true, and it doesn't explain why it says what it says.
It kinda looks like an ugly "maybe this will shut Paul up patch <grin>". I'd rather leave the code the way it was than add that comment ... sorry. > I'd like to avoid respinning this set Ah - now we get to the real issue ?;). There would be no need to respin; one could do just as you proposed doing with the above change, queue a little add-on patch to the existing set. Really ... look around the kernel. I believe you'll see many instances of enum values being spelled out, even ones that count 0, 1, 2, ..., in situations where the values are constrained by outside forces. People really do avoid relying on the default enum behaviour having any particular numbering. Whatever ... do as you will. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL PROTECTED]> 1.940.382.4214 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/