Am 09.07.2012 09:37, schrieb Shmulik Ladkani: > Hi Richard, > > On Sun, 08 Jul 2012 14:07:41 +0200 Richard Weinberger <rich...@nod.at> wrote: >>> + /* TODO: in the new locking scheme, produce_free_peb is >>> + * called under wl_lock taken. >>> + * so when returning, should reacquire the lock >>> + */ >> >> Which new locking scheme? > > I am diffing linux-ubi fastmap HEAD against its fork point (vanilla > ubi), that's 6b16351..d41a140 on linux-ubi. > > Which gives the following diff in produce_free_pebs:
Ahh. _my_ new locking scheme. I feared someone else changed it meanwhile in mainline. ;) Yes, the &ubi->wl_lock in produce_free_peb() is no longer needed. Again, thanks for pointing this out! Thanks, //richard
signature.asc
Description: OpenPGP digital signature