On Mon, 9 Jul 2012 19:16:24 +0100, Jason Vas Dias <jason.vas.d...@gmail.com> wrote: > Thanks Rusty - sorry I didn't see your email until now - revised patch > addressing your comments attached - > BTW, sorry about the word wrap on the initial posting - should I > attach a '.patch' file or inline ? Trying both .
The inline one was wrapped. > +static int thermal_temp_b4_trip(const struct dmi_system_id *d) { > + > + printk(KERN_NOTICE "ACPI: %s detected: : " > + "getting temperature before trip point > initialisation\n", d->ident); > + temp_b4_trip = TRUE; > + return 0; > +} TRUE? true is standard with stdbool.h. The patch itself looks reasonable, but it's not my area: I just spotted the module_param() abuse :) Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/