On 2012-07-11 11:20, Ian Abbott wrote:
On 2012-07-11 00:36, H Hartley Sweeten wrote:
My main concern with this series of patches is they make it harder to
determine what the register accesses actually do, mainly due to the
removal of useful comments. For example:
- RtdPacerStart(dev); /* Start PACER */
+ readl(devpriv->las0 + LAS0_PACER);
And:
- RtdPacerStop(dev); /* Stop PACER */
+ writel(0, devpriv->las0 + LAS0_PACER);
It would be too much work to redo all those patches though. I'll just
make a patch to add back in the useful-looking comments.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
