Typically, the return value desired for the failure of a function with an integer return value is a negative integer. In these cases, the return value is sometimes a negative integer and sometimes 0, due to a subsequent initialization of the return variable within the loop.
The semantic match that finds this problem is: (http://coccinelle.lip6.fr/) //<smpl> @r exists@ identifier ret; position p; constant C; expression e1,e2,e3,e4; @@ ret = -C ... when != ret = e1 when != ret += e1 when any if@p (...) { ... when != ret = e2 when != ret + e2 return ret; } ... when any if (\(ret != 0\|ret < 0\|ret > 0\) || ...) { ... return ...; } ... when != ret = e3 when != ret += e3 when any if@p (...) { ... when != ret = e4 when != ret += e4 return ret; } @@ identifier r.ret; position r.p; statement S; @@ ( if@p (<+...ret...+>) S | *if@p (...) S ) //</smpl> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
