On Sat, 2012-07-14 at 23:48 +0300, Pekka Enberg wrote: > On Sat, Jul 14, 2012 at 11:43 PM, Joe Perches <[email protected]> wrote: > > On Sat, 2012-07-14 at 13:36 -0700, Yinghai Lu wrote: > >> On Sat, Jul 14, 2012 at 6:41 AM, Pekka Enberg <[email protected]> wrote: > >> > As a cleanup, move initial "addr" assignment to the for-loop construct > >> > in free_init_pages(). > > > > Not really a good idea. > > Of course it's a good idea. The current code flow makes no sense. > > >> > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c > > [] > >> > @@ -349,8 +349,6 @@ void free_init_pages(char *what, unsigned long > >> > begin, unsigned long end) > >> > if (begin >= end) > >> > return; > >> > > >> > - addr = begin; > >> > - > >> > /* > >> > * If debugging page accesses then do not free this memory but > >> > * mark them not present - any buggy init-section access will > >> > @@ -371,7 +369,7 @@ void free_init_pages(char *what, unsigned long > >> > begin, unsigned long end) > >> > > >> > printk(KERN_INFO "Freeing %s: %luk freed\n", what, (end - begin) > >> > >> 10); > >> > > >> > - for (; addr < end; addr += PAGE_SIZE) { > >> > + for (addr = begin; addr < end; addr += PAGE_SIZE) { > >> > ClearPageReserved(virt_to_page(addr)); > >> > init_page_count(virt_to_page(addr)); > >> > memset((void *)addr, POISON_FREE_INITMEM, PAGE_SIZE); > >> > -- > > > > Now there's an unused variable warning when CONFIG_DEBUG_PAGEALLOC > > Sure, that needs fixing. It'd probably be simplest to introduce a > __free_init_pages() helper. >
The proposed patch introduces a warning. That's the only reason it's not a good idea. There are lots of ways to fix it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
