On Tue, Jul 10, 2012 at 3:45 AM, Devendra Naga <[email protected]> wrote: > the driver duplicates the module_pci_driver code, > how? > module_pci_driver is used for those drivers whose > init and exit paths does only register and unregister > to pci API and nothing else. > > so use the module_pci_driver macro instead > > Signed-off-by: Devendra Naga <[email protected]> > --- > drivers/staging/media/solo6x10/core.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/staging/media/solo6x10/core.c > b/drivers/staging/media/solo6x10/core.c > index d2fd842..3ee9b12 100644 > --- a/drivers/staging/media/solo6x10/core.c > +++ b/drivers/staging/media/solo6x10/core.c > @@ -318,15 +318,4 @@ static struct pci_driver solo_pci_driver = { > .remove = solo_pci_remove, > }; > > -static int __init solo_module_init(void) > -{ > - return pci_register_driver(&solo_pci_driver); > -} > - > -static void __exit solo_module_exit(void) > -{ > - pci_unregister_driver(&solo_pci_driver); > -} > - > -module_init(solo_module_init); > -module_exit(solo_module_exit); > +module_pci_driver(solo_pci_driver);
Acked-by: Ismael Luceno <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

