On Sun, 22 Jul 2012 13:55:22 +0545, Devendra Naga wrote: > with the commit 67ff19 (Thermal: Make Thermal trip points writeable) > build error is introduced, > > the following was reported from Fengguang Wu, > > drivers/thermal/thermal_sys.c: In function 'create_trip_attrs': > drivers/thermal/thermal_sys.c:1216:3: error: 'count' undeclared (first use in > this function) > drivers/thermal/thermal_sys.c:1216:3: note: each undeclared identifier is > reported only once for each function it appears in > > link: > http://www.spinics.net/lists/linux-kernel-janitors/msg12174.html > > use the indx instead.
Thanks for the fix. > Cc: Durgadoss R <durgados...@intel.com> > Signed-off-by: Devendra Naga <develkernel412...@gmail.com> > --- > > This patch is build-tested only. Something the original submitter apparently didn't do. Durga, can you please build-test all your commits from now on? I don't even understand how you managed to test your code if it did not build... The broken commit isn't upstream yet, so in the interest of bisectability I would recommend that the original commit is fixed and the branch in which this broken commit was is rebased. Only then, ask Linux to pull from it. Thanks. > > drivers/thermal/thermal_sys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 9f56250..1b4aa9d 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -1259,7 +1259,7 @@ static int create_trip_attrs(struct thermal_zone_device > *tz, int flag) > snprintf(tz->trip_type_attrs[indx].name, THERMAL_NAME_LENGTH, > "trip_point_%d_type", indx); > > - sysfs_attr_init(&tz->trip_type_attrs[count].attr.attr); > + sysfs_attr_init(&tz->trip_type_attrs[indx].attr.attr); > tz->trip_type_attrs[indx].attr.attr.name = > tz->trip_type_attrs[indx].name; > tz->trip_type_attrs[indx].attr.attr.mode = S_IRUGO; -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
