* Sam Ravnborg <s...@ravnborg.org> wrote:
> >
> > No, the reason for the odd looking diff is that lots of lines in
> > arch/x86/Makefile have 8-space tabs for histerical reasons but
> > new code (such as this one) has proper tabs.
>
> Use of tabs for indent in a Makefile is just asking for
> trouble.
Ok, I guess you are right - see the patch below which was
another type of bug that could be introduced via not using
spaces properly.
We could do it the other way around: turn all tabs into spaces
and add Makefile checking in kbuild so that the build fails if
a tab is added to a Makefile?
Alternatively, is there perhaps some way to teach make to not be
so broken to depend on whitespace details that are *invisible*
to humans?
Thanks,
Ingo
Index: linux/arch/x86/Makefile
===================================================================
--- linux.orig/arch/x86/Makefile
+++ linux/arch/x86/Makefile
@@ -96,7 +96,7 @@ ifdef CONFIG_X86_X32
KBUILD_AFLAGS += -DCONFIG_X86_X32_ABI
KBUILD_CFLAGS += -DCONFIG_X86_X32_ABI
else
- $(warning CONFIG_X86_X32 enabled but no binutils support)
+ $(warning CONFIG_X86_X32 enabled but no binutils support)
endif
endif
export CONFIG_X86_X32_ABI
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
