On 07/25/2012 01:47 PM, Cyrill Gorcunov wrote: > This patch converts /proc/pid/fdinfo/ handling routines to seq-file which > is needed to extend seq operations and plug in auxiliary fdinfo provides > from subsystems like eventfd/eventpoll/fsnotify. > > Note the proc_fd_link no longer call for proc_fd_info, simply because > proc_fd_info is converted to seq_fdinfo_open (which is seq-file open() > prototype), moreover in further patches I need to provide two seq_fdinfo_open > variants -- one with CONFIG_CHECKPOINT_RESTORE and one without this > symbol. All in one -- this will look more messy then.
This is something I'm really not happy with :( After the set applied we will have one former proc_fd_info being splitted into 3 (three!) functions doing the same (with flavors). For me it's better to fix this, otherwise conversion to seq-file looks OK. > Signed-off-by: Cyrill Gorcunov <[email protected]> > CC: Al Viro <[email protected]> > CC: Alexey Dobriyan <[email protected]> > CC: Andrew Morton <[email protected]> > CC: Pavel Emelyanov <[email protected]> > CC: James Bottomley <[email protected]> > --- > fs/proc/fd.c | 133 > +++++++++++++++++++++++++++++++++++++---------------------- > 1 file changed, 85 insertions(+), 48 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
