Jiri Kosina <jkos...@suse.cz> writes:

>       if (personality(current->personality) == PER_LINUX32
> -         && personality == PER_LINUX)
> -             personality = PER_LINUX32;
> +         && personality(personality) == PER_LINUX)
> +             personality &= ~PER_LINUX | PER_LINUX32;

That doesn't work.  ~PER_LINUX is -1, so this is a no-op.

>       ret = sys_personality(personality);
> -     if (ret == PER_LINUX32)
> -             ret = PER_LINUX;
> +     if (personality(ret) == PER_LINUX32)
> +             ret &= ~PER_LINUX32 | PER_LINUX;

That only "works" because PER_LINUX is 0.

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to