On Wed, Aug 01, 2012 at 02:10:59PM +0400, Jiri Olsa wrote:
> From: Frederic Weisbecker <fweis...@gmail.com>
>
> Introducing following bits to the the perf_event_attr struct:
> - exclude_callchain_kernel to filter out kernel callchain
> from the sample dump
> - exclude_callchain_user to filter out user callchain
> from the sample dump
>
> We need to be able to disable standard user callchain dump
> when we use the dwarf cfi callchain mode, because frame
> pointer based user callchains are useless in this mode.
>
> Implementing also exclude_callchain_kernel to have complete
> set of options.
>
> Signed-off-by: Frederic Weisbecker <fweis...@gmail.com>
> [ Added kernel callchains filtering ]
> Signed-off-by: Jiri Olsa <jo...@redhat.com>
> CC: Andrew Vagin <ava...@openvz.org>
Acked-by: Andrew Vagin <ava...@openvz.org>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index c4582bb..0902d4a 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -4130,8 +4130,12 @@ void perf_prepare_sample(struct perf_event_header
> *header,
>
> if (sample_type & PERF_SAMPLE_CALLCHAIN) {
> int size = 1;
> + int kernel = !event->attr.exclude_callchain_kernel;
> + int user = !event->attr.exclude_callchain_user;
>
> - data->callchain = perf_callchain(event, regs);
> + if (kernel || user)
> + data->callchain = perf_callchain(event, regs,
> + kernel, user);
I am not sure, that we need two arguments kernel and user here,
we can get them from event inside perf_callchain...
>
> if (data->callchain)
> size += data->callchain->nr;
> diff --git a/kernel/events/internal.h b/kernel/events/internal.h
> index ce7bdfc..95d0215 100644
> --- a/kernel/events/internal.h
> +++ b/kernel/events/internal.h
> @@ -126,7 +126,8 @@ DEFINE_OUTPUT_COPY(__output_copy_user,
> arch_perf_out_copy_user)
>
> /* Callchain handling */
> extern struct perf_callchain_entry *
> -perf_callchain(struct perf_event *event, struct pt_regs *regs);
> +perf_callchain(struct perf_event *event, struct pt_regs *regs,
> + int kernel, int user);
> extern int get_callchain_buffers(void);
> extern void put_callchain_buffers(void);
>
> --
> 1.7.7.6
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
