> -----Original Message----- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Thursday, August 02, 2012 8:18 PM > To: Virupax SADASHIVPETIMATH > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux- > ker...@vger.kernel.org; Praveena NADAHALLY > Subject: Re: [PATCH] usb:musb:musb_host: Handle highmem in PIO mode > > > --- a/include/linux/usb.h > > +++ b/include/linux/usb.h > > @@ -21,6 +21,7 @@ > > #include <linux/sched.h> /* for current && schedule_timeout */ > > #include <linux/mutex.h> /* for struct mutex */ > > #include <linux/pm_runtime.h> /* for runtime PM */ > > +#include <linux/scatterlist.h> > > > > struct usb_device; > > struct usb_driver; > > @@ -1309,6 +1310,7 @@ struct urb { > > usb_complete_t complete; /* (in) completion routine */ > > struct usb_iso_packet_descriptor iso_frame_desc[0]; > > /* (in) ISO ONLY */ > > + struct sg_mapping_iter sg_miter; /* handling highmem data in PIO mode */ > > }; > > This is unacceptable. Fields like this should be stored in the > URB's hcpriv structure, not in the URB itself.
Ok I will add it in the hcpriv structure. Can you please comment on other part of the code also, so that all the changes can be done together. Thanks Virupax S -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
