Ingo, just a "ping" message, so that this change won't be forgotten. It was waiting for v3.6: https://lkml.org/lkml/2012/6/6/134
thank you! Anton. On Fri, 2012-06-01 at 14:49 +0530, Srikar Dronamraju wrote: > From: Srikar Dronamraju <sri...@linux.vnet.ibm.com> > > Since read_opcode() reads from the referenced page and doesnt modify > the page contents nor the page attributes, there is no need to lock > the page. > > Signed-off-by: Srikar Dronamraju <sri...@linux.vnet.ibm.com> > --- > Modified changelog based on comments from Peter Zijlstra > > kernel/events/uprobes.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 42b21eb..b3f3095 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -315,12 +315,10 @@ static int read_opcode(struct mm_struct *mm, unsigned > long vaddr, uprobe_opcode_ > if (ret <= 0) > return ret; > > - lock_page(page); > vaddr_new = kmap_atomic(page); > vaddr &= ~PAGE_MASK; > memcpy(opcode, vaddr_new + vaddr, UPROBE_SWBP_INSN_SIZE); > kunmap_atomic(vaddr_new); > - unlock_page(page); > > put_page(page); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
