Hi Koen, On Tue, Aug 7, 2012 at 6:24 PM, Koen Kooi <[email protected]> wrote: > > Op 3 aug. 2012, om 14:38 heeft Sourav Poddar <[email protected]> het > volgende geschreven: > >> Add keypad data node in omap5 device tree file. >> Also fill the device tree binding parameters >> with the required value in "omap5-evm" dts file. >> >> Tested on omap5430 evm with 3.5 custom kernel. >> >> Cc: Benoit Cousson <[email protected]> >> Cc: Felipe Balbi <[email protected]> >> Cc: Santosh Shilimkar <[email protected]> >> Acked-by: Felipe Balbi <[email protected]> >> Signed-off-by: Sourav Poddar <[email protected]> >> --- >> arch/arm/boot/dts/omap5-evm.dts | 12 ++++++++++++ >> arch/arm/boot/dts/omap5.dtsi | 5 +++++ >> 2 files changed, 17 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap5-evm.dts >> b/arch/arm/boot/dts/omap5-evm.dts >> index 45a8aeb..09fe941 100644 >> --- a/arch/arm/boot/dts/omap5-evm.dts >> +++ b/arch/arm/boot/dts/omap5-evm.dts >> @@ -17,6 +17,18 @@ >> device_type = "memory"; >> reg = <0x80000000 0x40000000>; /* 1 GB */ >> }; >> + >> + keypad { >> + keypad,num-rows = <8>; >> + keypad,num-columns = <8>; >> + linux,keymap = < 0x02020073 >> + 0x02030072 >> + 0x020400e7 >> + 0x02050066 >> + 0x0206006b >> + 0x020700d9 >; >> + linux,input-no-autorepeat; >> + }; > > Again not a coment on your patch, but on DT: > > If DT bindings must be OS independent, what then, is that linux keycode doing > there? > Currently, for all matrix connected keyboards the keymap are defined in the scope of the linux key code since that is a stable and standardized interface at this time.
For the above reason , computation of the keymap uses linux keycode row << 24 | column << 16 | linux-key-code I think this is the primary reason for keeping "linux" prefix with this property. > regards, > > Koen > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
