From: Greg KH <[email protected]> 3.5-stable review patch. If anyone has any objections, please let me know.
------------------ From: Antonio Quartulli <[email protected]> commit d2b6cc8e460494251442a877fcbc150faa175b4f upstream. skb_linearize(skb) possibly rearranges the skb internal data and then changes the skb->data pointer value. For this reason any other pointer in the code that was assigned skb->data before invoking skb_linearise(skb) must be re-assigned. In the current tt_query message handling code this is not done and therefore, in case of skb linearization, the pointer used to handle the packet header ends up in pointing to poisoned memory. The packet is then dropped but the translation-table mechanism is corrupted. Signed-off-by: Antonio Quartulli <[email protected]> Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- net/batman-adv/routing.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/batman-adv/routing.c +++ b/net/batman-adv/routing.c @@ -626,6 +626,8 @@ int recv_tt_query(struct sk_buff *skb, s if (unlikely(skb_headlen(skb) < sizeof(struct tt_query_packet) + tt_len)) goto out; + /* skb_linearize() possibly changed skb->data */ + tt_query = (struct tt_query_packet *)skb->data; handle_tt_response(bat_priv, tt_query); } else { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
