On Aug 8, 2012, at 1:31 PM, Milan Broz wrote: > On 08/08/2012 08:46 PM, Mikulas Patocka wrote: > >> The problem with the patch is that it changes interface to the userspace >> tool. The userspace tool veritysetup already exists in recent cryptsetup >> package, so we can't change the interface - you should change the patch so >> that the starting data block is the last argument and the argument is >> optional - so that it is compatible with the existing userspace too. > > yes. Please never change interface without at least increasing target version. > > I have to add userspace support as well to veritysetup and we need a way > how to detect that option is supported by running kernel.
Understood. Thank you for the feedback. I will attempt a new patch version which addresses these issues. I also found that I did not correct the last-block boundary check so I will re-submit my patch with that as well. I did modify veritysetup on my own so the format and verify commands will work with regular files on disk instead of having to mount through loop devices. -- Wesley Miaw
signature.asc
Description: Message signed with OpenPGP using GPGMail
