On 08/09/2012 04:09 AM, Mark Brown wrote: > On Wed, Aug 08, 2012 at 03:18:45PM -0600, Stephen Warren wrote: > >> + rdev->desc->enable_mask | >> + rdev->desc->en_dis_set_mask | >> + rdev->desc->en_dis_clr_mask, >> + rdev->desc->enable_mask | >> + rdev->desc->en_dis_set_mask); > > Two problems here. One is that the names are *really* obscure and hard > to read, the other is that this breaks all existing users.
OK. I can change this to whatever names you suggest. enable_disable_clear_mask seems the least obscure, but rather long. Just let me know what you want. As for breaking existing users, I don't think so: The new fields will presumably be initialized to zero for any drivers that don't explicitly set them, and the values are simply or'd into the mask/value parameters to update_bits(), and or'ing a zero will have no effect. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/