>-----Original Message----- >From: [email protected] [mailto:[email protected]] On >Behalf Of Ilya Shchepetkov > >For carrier detection to work properly when binding the driver with a >cable unplugged, netif_carrier_off() should be called after >register_netdev(), not before. > >Calling netif_carrier_off() before register_netdev() was causing the >network interface to miss a linkwatch pending event leading to an >inconsistent state if the link is not up when interface is initialized.
ndo_open() may be called as soon register_netdev() completes... When netif_carrier_off() is called *after* register_netdev(), isn't there a possibility of a ndo_open()->netif_carrier_on() call racing this call, causing incorrect results? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
