On Wed, 2012-08-15 at 15:01 +0200, Oleg Nesterov wrote: > BTW, set_task_comm()->wmb() and memset() should die. There are > not needed afaics, and the comment is misleading.
As long as we guarantee there's always a terminating '\0', now strlcpy() doesn't pad the result, however if we initialize the ->comm to all 0s in fork() or thereabouts, we should get this guarantee from the strlcpy() since that will never replace the last byte with anything but 0. That barrier is indeed completely pointless as there's no pairing barrier anywhere. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
