Hi Andrew, Already an updated patch v3 (http://lkml.org/lkml/2012/8/8/221 ) was pushed to fix these issues. Plz review and merged that.
Thanks, Venu > -----Original Message----- > From: Andrew Morton [mailto:a...@linux-foundation.org] > Sent: Wednesday, August 15, 2012 5:22 AM > To: Venu Byravarasu > Cc: a.zu...@towertech.it; sa...@linux.intel.com; > broo...@opensource.wolfsonmicro.com; Laxman Dewangan; > kyle.ma...@fuel7.com; rtc-li...@googlegroups.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC > > On Thu, 26 Jul 2012 12:05:19 +0530 > Venu Byravarasu <vbyravar...@nvidia.com> wrote: > > > TPS65910 PMIC is a MFD with RTC as one of the device. > > Adding RTC driver for supporting RTC device present > > inside TPS65910 PMIC. > > > > Only support for RTC alarm is implemented as part of this patch. > > It needs a build fix: > > drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_suspend': > drivers/rtc/rtc-tps65910.c:313: error: request for member 'irqstat' in > something not a structure or union > drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_resume': > drivers/rtc/rtc-tps65910.c:327: error: request for member 'irqstat' in > something not a structure or union > > --- a/drivers/rtc/rtc-tps65910.c~rtc-tps65910-add-rtc-driver-for-tps65910- > pmic-rtc-fix > +++ a/drivers/rtc/rtc-tps65910.c > @@ -310,7 +310,7 @@ static int tps65910_rtc_suspend(struct p > > /* Store current list of enabled interrupts*/ > ret = regmap_read(tps->regmap, TPS65910_RTC_INTERRUPTS, > - &tps->rtc.irqstat); > + &tps->rtc->irqstat); > if (ret < 0) > return ret; > > @@ -324,7 +324,7 @@ static int tps65910_rtc_resume(struct pl > > /* Restore list of enabled interrupts before suspend */ > return regmap_write(tps->regmap, TPS65910_RTC_INTERRUPTS, > - tps->rtc.irqstat); > + tps->rtc->irqstat); > } > > static const struct dev_pm_ops tps65910_rtc_pm_ops = { > > > but it still has problems: > > drivers/rtc/rtc-tps65910.c:331: warning: initialization from incompatible > pointer type > drivers/rtc/rtc-tps65910.c:332: warning: initialization from incompatible > pointer type > > fix and resend, please? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
