On Thu, 2012-08-16 at 15:13 -0400, Josh Boyer wrote: > On Thu, Aug 16, 2012 at 3:08 PM, Mimi Zohar <[email protected]> wrote: > >> > +#include "internal.h" > >> > +static int __init init_root_keyring(void) > >> > +{ > >> > + return install_user_keyrings(); > >> > +} > >> > + > >> > +late_initcall(init_root_keyring); > >> > -- > >> > >> Why is this in an entirely new file instead of just being added to > >> process_keys.c ? > >> > >> josh > > > > Only when "CONFIG_INTEGRITY_SIGNATURE" is selected, does this get built. > > Yes, I noticed that. It doesn't explain why it's in its own file. You > could accomplish the same thing by wrapping the function and initcall > in #ifdef CONFIG_INTEGRITY_SIGNATURE in process_keys.c.
I was under the impression using 'ifdefs' in 'C' code was frowned upon (Documentation/SubmittingPatches section 2.2). This would be an exception? Mimi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
