On 2012-08-28 11:03, Martin K. Petersen wrote:
>
> DM would occasionally end up splitting data integrity-enabled requests
> incorrectly. The culprit was a bad range check in bio_sector_offset.
>
> Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com>
> Cc: <sta...@vger.kernel.org>
>
> diff --git a/fs/bio.c b/fs/bio.c
> index 9bfade8..b9a6744 100644
> --- a/fs/bio.c
> +++ b/fs/bio.c
> @@ -1552,8 +1552,8 @@ sector_t bio_sector_offset(struct bio *bio, unsigned
> short index,
> sector_sz = queue_logical_block_size(bio->bi_bdev->bd_disk->queue);
> sectors = 0;
>
> - if (index >= bio->bi_idx)
> - index = bio->bi_vcnt - 1;
> + if (index > bio->bi_vcnt)
> + return 0;
>
> __bio_for_each_segment(bv, bio, i, 0) {
> if (i == index) {
Good catch, merged.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
