LP8727 driver should be patched for several reasons.
(a) Need to clean up _probe()/_remove()
(b) Not secure code when the platform data is NULL
(c) Interrupt handling
Two threads are running for handling one IRQ.
One is for the IRQ pin, the other is used for delayed processing.
This is unusual and can be enhanced.
(d) Misuse of mutex code
(e) Lots of definitions should be fixed
(f) Others..
Bunch of code patches are as below.
[PATCH 1/8] lp8727_charger: use devm_kzalloc() rather than
kzalloc()/kfree()
[PATCH 2/8] lp8727_charger: cleanup _probe() and _remove()
[PATCH 3/8] lp8727_charger: fix buggy code when the platform data is
NULL
[PATCH 4/8] lp8727_charger: cleanup the interrupt handler code
[PATCH 5/8] lp8727_charger: move the mutex code
[PATCH 6/8] lp8727_charger: fix code for getting battery temperature
[PATCH 7/8] lp8727_charger: cleanup definitions
[PATCH 8/8] lp8727_charger: make cosmetic code
Best Regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
