any comments ?
On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga
<develkernel412...@gmail.com> wrote:
> actually we can do returns with error or success with out ret in this
> function,
> so remove the ret variable, and reduce a very little (4byte) space on stack
> of this function
>
> Signed-off-by: Devendra Naga <develkernel412...@gmail.com>
> ---
> compile tested.
>
> drivers/extcon/extcon-max8997.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index ef9090a..77b66b0 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -271,8 +271,6 @@ out:
> static int max8997_muic_handle_charger_type_detach(
> struct max8997_muic_info *info)
> {
> - int ret = 0;
> -
> switch (info->pre_charger_type) {
> case MAX8997_CHARGER_TYPE_USB:
> extcon_set_cable_state(info->edev, "USB", false);
> @@ -290,11 +288,11 @@ static int max8997_muic_handle_charger_type_detach(
> extcon_set_cable_state(info->edev, "Fast-charger", false);
> break;
> default:
> - ret = -EINVAL;
> + return -EINVAL;
> break;
> }
>
> - return ret;
> + return 0;
> }
>
> static int max8997_muic_handle_charger_type(struct max8997_muic_info *info,
> --
> 1.7.12.rc2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
