Hello. On 04-09-2012 15:35, Andi Shyti wrote:
+static int __devinit syscon_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev;
Do we really need this variable? Anyway you are using it only once in the dev_info.
But Dong definitely could use it more than once, so it seems useful.
+ struct device_node *np = dev->of_node; + struct syscon *syscon; + struct resource res; + int ret; + + if (!np) + return -ENOENT; + + syscon = devm_kzalloc(&pdev->dev, sizeof(struct syscon), + GFP_KERNEL); + if (!syscon) + return -ENOMEM; + + syscon->base = of_iomap(np, 0); + if (!syscon->base) + return -EADDRNOTAVAIL; + + ret = of_address_to_resource(np, 0, &res); + if (ret) + return ret; + + syscon_regmap_config.max_register = res.end - res.start - 3; + syscon->regmap = devm_regmap_init_mmio(&pdev->dev, syscon->base, + &syscon_regmap_config); + if (IS_ERR(syscon->regmap)) { + dev_err(&pdev->dev, "regmap init failed\n"); + return PTR_ERR(syscon->regmap); + } + + syscon->dev = &pdev->dev; + platform_set_drvdata(pdev, syscon); + + dev_info(dev, "syscon regmap start 0x%x end 0x%x registered\n", + res.start, res.end); + + return 0;
in case of error you are not freeing syscon.
It's allocated using devm_kzalloc(), so is freed automaticelly upon probe error.
Moreover, in my opinion, some dev_err more should not heart
Hurt, you mean?
Andi
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
