On 12-08-31 05:22 PM, Dmitry Torokhov wrote: > On Fri, Aug 31, 2012 at 04:57:04PM -0600, Mathieu Poirier wrote: >> On 12-08-31 04:41 PM, Dmitry Torokhov wrote: >>> On Fri, Aug 31, 2012 at 11:02:27PM +0100, Alan Cox wrote: >>>>>> Why do we need to involve a platform device and not use, for example, a >>>>>> module >>>>>> parameter, that could be set up from userspace? >>>>> >>>>> The platform device comes from the original design and was included to >>>>> minimise the amount of changes in code that make use of the current >>>>> keyreset driver. >>>> >>>> The platform device is IMHO the right answer. In this class of devices >>>> the stuff is compiled in, the userspace is Android, there are no modules >>>> and there is no reason for it to be configurable. >>> >>> It does not matter if it is built in or not, /sys/module/XXX/parameters >>> is still there, and while havig it in kernel is "easy" you could as >>> easily stuff needed data into a sysfs attribute during booting. >>> >>> And we should be able to get this from DT even without the platform >>> device (this was the next step, wasn't it?). >> >> Correct - my hope was to get the main functionality accepted before >> adding DT support. Do you think the lack of DT support is a blocker for >> acceptance ? Please confirm. >> > > No, lack of DT is not a blocker, but I am unconvinced that we need > platform device. > > Thanks, >
A platform device is really easy to spin-off in a board file and once it is there you don't have to worry about other loose ends to tie in before the solution is functional. I don't mind supplementing the current proposition with a module parameter interface to get the "key_down" and "key_up" sequences. Which brings us to the "reset_fn()" function - in my opinion it offers significant advantages and should be kept in the design. What I'm not so clear about is on the implementation. Should it be kept as part of a platform data or be implemented as a notifier as suggested by Alan. I am looking for guidance here and suggestions are encouraged. Regards, Mathieu. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/