On Wed, Sep 05, 2012 at 01:46:21PM +0100, Alan Cox wrote:
> On Wed, 5 Sep 2012 03:29:32 +0100
> Matthew Garrett <m...@redhat.com> wrote:
>
> > On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote:
> > > > /*
> > > >+ * Some devices may provide ROMs via a source other than the BAR
> > > >+ */
> > > >+ if (pdev->rom&& pdev->romlen) {
> > > >+ *size = pdev->romlen;
> > > >+ return phys_to_virt((phys_addr_t)pdev->rom);
> > > ^^^^^
> > > ioremap_nocache() ? ... or is caching rom ok?
> >
> > If it's appearing through this pathway then it's not actually in ROM,
> > the platform has pulled it out of somewhere else.
>
> If that somewhere else is on the PCI bus then it should be a bus not a
> virt translation surely ?
We've no good way of knowing what the firmware's giving us - we copy it
to RAM in the EFI init process, so by the time we're here it certainly
shouldn't be on the PCI bus.
--
Matthew Garrett | mj...@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
