At 09/06/2012 03:27 PM, andywu106建国 Wrote: > 2012/9/5 <[email protected]> >> >> From: Wen Congyang <[email protected]> >> >> hwpoisoned may set when we offline a page by the sysfs interface >> /sys/devices/system/memory/soft_offline_page or >> /sys/devices/system/memory/hard_offline_page. If we don't clear >> this flag when onlining pages, this page can't be freed, and will >> not in free list. So we can't offline these pages again. So we >> should clear this flag when onlining pages. >> >> CC: David Rientjes <[email protected]> >> CC: Jiang Liu <[email protected]> >> CC: Len Brown <[email protected]> >> CC: Benjamin Herrenschmidt <[email protected]> >> CC: Paul Mackerras <[email protected]> >> CC: Christoph Lameter <[email protected]> >> Cc: Minchan Kim <[email protected]> >> CC: Andrew Morton <[email protected]> >> CC: KOSAKI Motohiro <[email protected]> >> CC: Yasuaki Ishimatsu <[email protected]> >> Signed-off-by: Wen Congyang <[email protected]> >> --- >> mm/memory_hotplug.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 270c249..140c080 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -661,6 +661,11 @@ EXPORT_SYMBOL_GPL(__online_page_increment_counters); >> >> void __online_page_free(struct page *page) >> { >> +#ifdef CONFIG_MEMORY_FAILURE >> + /* The page may be marked HWPoisoned by soft/hard offline page */ >> + ClearPageHWPoison(page); > > Hi Congyang, > I think you should decrease mce_bad_pages counter her > atomic_long_sub(1, &mce_bad_pages);
Yes, thanks for pointing it out. Thanks Wen Congyang > >> >> +#endif >> + >> ClearPageReserved(page); >> init_page_count(page); >> __free_page(page); >> -- >> 1.7.1 >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to [email protected]. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: <a href=mailto:"[email protected]";> [email protected] </a> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
