On Thu, 6 Sep 2012 15:10:14 +1000
Stephen Rothwell <[email protected]> wrote:
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from drivers/tty/serial/sccnxp.c:20:0:
> include/linux/serial_core.h: In function 'uart_handle_break':
> include/linux/serial_core.h:543:30: error: dereferencing pointer to
> incomplete type
>
> Caused by commit 1d65c0b12656 ("serial: New serial driver SCCNXP").
> This seems to be just exposing a preexisting problem with
> linux/serial_core.h: when SUPPORT_SYSRQ is defined, this header
> depends on linux/console.h. I can only imagein that every other use
> of serial_core.h pre-includes (maybe indirectly) console.h (or
> doesn't define SUPPORT_SYSRQ).
>
> I have applied the following patch, but a better solution should be
> figured out.
I think thats actually probably the right patch. Better to keep the
header explicit than try and build some tangled mess of recursive
includes.
Acked-by: Alan Cox <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
