On Thu, 06 September 2012 Emil Goode <emilgo...@gmail.com> wrote:
> The flush_delayed_work_sync function is deprecated,
> we can instead call flush_delayed_work directly.
> 
> Sparse is giving a warning:
> drivers/hid/hid-picolcd_fb.c:611:2: warning:
>       ‘flush_delayed_work_sync’ is deprecated
>       (declared at include/linux/workqueue.h:454)
>       [-Wdeprecated-declarations]
> 
> Signed-off-by: Emil Goode <emilgo...@gmail.com>

Acked-by: Bruno Prémont <bonb...@linux-vserver.org>

This matches a patch by Tejun a few weeks ago which was partially
skipped in -next due to merge conflict with code split in picoLCD.

See http://comments.gmane.org/gmane.linux.kernel.next/23740

For the sake of proper bisectability, this should go in after
Tejun's workqueue changes (if needed at all depending on how merge
happens during pull by Linus).

Bruno

> ---
>  drivers/hid/hid-picolcd_fb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
> index 0008a51..eb00357 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -608,7 +608,7 @@ void picolcd_exit_framebuffer(struct picolcd_data *data)
>       /* make sure there is no running update - thus that fbdata->picolcd
>        * once obtained under lock is guaranteed not to get free() under
>        * the feet of the deferred work */
> -     flush_delayed_work_sync(&info->deferred_work);
> +     flush_delayed_work(&info->deferred_work);
>  
>       data->fb_info = NULL;
>       unregister_framebuffer(info);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to