Re: [PATCH] perf, ibs: Check syscall attribute flags

[David Ahern]

On 9/7/12 10:41 AM, Robert Richter wrote:
+       struct perf_event_attr notsupp = {
+               .exclude_user   = 1,
+               .exclude_kernel = 1,
+               .exclude_hv     = 1,
+               .exclude_idle   = 1,
+               .exclude_host   = 1,
+               .exclude_guest  = 1,
+       };
        perf_ibs = get_ibs_pmu(event->attr.type);
        if (perf_ibs) {
@@ -229,6 +237,9 @@ static int perf_ibs_init(struct perf_event *event)
        if (event->pmu != &perf_ibs->pmu)
                return -ENOENT;

+       if (perf_flags(&event->attr) & perf_flags(&notsupp))
+               return -EINVAL;
+

Am I reading this right - if exclude_guest is set then perf_ibs_init 
returns -EINVAL?

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/