On Sat, 8 Sep 2012 08:35:51 +0300, Irina Tirdea wrote: > From: Irina Tirdea <[email protected]> > > When NDEBUG is defined, the assert macro will be expanded to nothing. > Some assert calls used in perf are also including some functionality > (e.g. system calls), not only validity checks. Therefore, if NDEBUG is > defined, this functionality will be removed along with the assert. > Perf also defines BUG_ON based on assert, so it has the same problem. > > Define BUG_ON so that the condition will be executed when NDEBUG is defined. > Replace the assert statements that have these side effects with BUG_ON. > > For defining BUG_ON, use "if (cond) {}" insted of "if (cond) ;" because in > the latter case build fails with "error: suggest braces around empty body in > an ‘if’ statement [-Werror=empty-body]" > > Suggested-by: Peter Zijlstra <[email protected]> > Signed-off-by: Irina Tirdea <[email protected]>
Reviewed-by: Namhyung Kim <[email protected]> Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
