Looks OK to me, thanks.
On Sep 7, 2012, at 11:59 PM, "Dan Carpenter" <dan.carpen...@oracle.com> wrote:
> We changed this recently so we can just use kzalloc() here instead of
> kcalloc(1, ...). Kernel style prefers sizeof(*t) over sizeof *t. The
> kfree(t) is a no-op now as well so that can be removed.
>
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
> ---
> Only applies to linux-next.
>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 5461faa..c0adbbd 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -1255,9 +1255,8 @@ addtgt(struct aoedev *d, char *addr, ulong nframes)
> "aoe: device addtgt failure; too many targets\n");
> return NULL;
> }
> - t = kcalloc(1, sizeof *t, GFP_ATOMIC);
> + t = kzalloc(sizeof(*t), GFP_ATOMIC);
> if (!t) {
> - kfree(t);
> printk(KERN_INFO "aoe: cannot allocate memory to add target\n");
> return NULL;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
