On Tue 11-09-12 17:47:14, Will Deacon wrote: > From: Catalin Marinas <[email protected]> > > The CONFIG_TRANSPARENT_HUGEPAGE implementation of pmdp_get_and_clear() > calls pmd_clear() with 3 arguments instead of 1.
only for !__HAVE_ARCH_PMDP_GET_AND_CLEAR which doesn't seem to happen because x86 defines this and it uses pmd_update. > > Cc: Arnd Bergmann <[email protected]> > Signed-off-by: Catalin Marinas <[email protected]> > Signed-off-by: Steve Capper <[email protected]> > Signed-off-by: Will Deacon <[email protected]> Other than that it looks good. Reviewed-by: Michal Hocko <[email protected]> > --- > include/asm-generic/pgtable.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > index ff4947b..f7e0206 100644 > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -87,7 +87,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm, > pmd_t *pmdp) > { > pmd_t pmd = *pmdp; > - pmd_clear(mm, address, pmdp); > + pmd_clear(pmdp); > return pmd; > } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > -- > 1.7.4.1 > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
