On 09/12/2012 02:58 PM, Sebastian Andrzej Siewior wrote: > On 09/12/2012 08:02 PM, Cyril Chemparathy wrote: >>>> -void __init early_init_dt_setup_initrd_arch(unsigned long start, >>>> unsigned long end) >>>> +void __init early_init_dt_setup_initrd_arch(u64 start, u64 end) >>> >>> Why not phys_addr_t? >>> >> >> The rest of the memory specific bits of the device-tree code use u64 for >> addresses, and I kept it the same for consistency. > > Geert is right here. If it is a physical address, it should be > phys_addr_t.
While generally true, for the DT specific code I think it should be a fixed u64. The size of the address is defined by the FDT, not the kernel. It is very likely we could have a FDT that specifies addresses in 64-bit values, but then we boot a kernel is compiled for !LPAE. phys_addr_t is currently sized based on LPAE setting. Also, this is how the memory and reserved nodes are handled currently, so we should be consistent. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/